akadmin/chatwoot
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: Construct CDN asset URLs correctly with protocol and path

Browse Source 
- Add https:// protocol to ASSET_CDN_HOST if missing
- Include asset path (/vite/) when constructing CDN URLs
- Fix URL: https://cdn.example.com/vite/assets/file.css

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Pranav
2026-01-10 20:13:39 -08:00
co-authored by Claude Opus 4.5
parent adbee23e12
commit 8daac4cdd1
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/javascript/service-worker/build.js
+5 -1
View File
@@ -56,7 +56,11 @@ function generateAssetManifest() {
async function buildServiceWorker() {
console.log('🔨 Building service worker...');
const assetOrigin = process.env.ASSET_CDN_HOST || '';
// Ensure CDN host has protocol prefix for absolute URLs
let assetOrigin = process.env.ASSET_CDN_HOST || '';
if (assetOrigin && !assetOrigin.startsWith('http')) {
assetOrigin = `https://${assetOrigin}`;
}
const isProduction = process.env.NODE_ENV === 'production';
// vite-plugin-ruby serves from /vite/ in production, /vite-dev/ in development
const assetPath = isProduction ? '/vite/' : '/vite-dev/';
app/javascript/service-worker/sw-runtime.js
+8 -2
View File
@@ -123,7 +123,10 @@ async function prefetchAssets() {
if (!ASSET_MANIFEST?.length) return;
const cache = await caches.open(CACHE_NAME);
const baseUrl = ASSET_ORIGIN || `${self.location.origin}${ASSET_PATH}`;
// Build base URL: CDN origin + asset path, or local origin + asset path
const baseUrl = ASSET_ORIGIN
? `${ASSET_ORIGIN}${ASSET_PATH}`
: `${self.location.origin}${ASSET_PATH}`;
// Prefetch in batches of 5 (await in loop is intentional for throttling)
for (let i = 0; i < ASSET_MANIFEST.length; i += 5) {
@@ -171,7 +174,10 @@ async function cleanupStaleAssets() {
const cache = await caches.open(CACHE_NAME);
const cachedRequests = await cache.keys();
const baseUrl = ASSET_ORIGIN || `${self.location.origin}${ASSET_PATH}`;
// Build base URL: CDN origin + asset path, or local origin + asset path
const baseUrl = ASSET_ORIGIN
? `${ASSET_ORIGIN}${ASSET_PATH}`
: `${self.location.origin}${ASSET_PATH}`;
// Build set of valid asset URLs from current manifest
const validUrls = new Set(