diff --git a/app/controllers/devise_overrides/sessions_controller.rb b/app/controllers/devise_overrides/sessions_controller.rb index 974fb05e4..bd7bb9b44 100644 --- a/app/controllers/devise_overrides/sessions_controller.rb +++ b/app/controllers/devise_overrides/sessions_controller.rb @@ -25,6 +25,14 @@ class DeviseOverrides::SessionsController < DeviseTokenAuth::SessionsController private + def render_create_error_not_confirmed + render_error( + :unauthorized, + I18n.t('devise_token_auth.sessions.not_confirmed', email: @resource.email), + error_code: 'user_not_confirmed' + ) + end + def find_user_for_authentication return nil unless params[:email].present? && params[:password].present? diff --git a/app/javascript/v3/api/auth.js b/app/javascript/v3/api/auth.js index c4ef40b1c..4c4ffb13e 100644 --- a/app/javascript/v3/api/auth.js +++ b/app/javascript/v3/api/auth.js @@ -2,6 +2,7 @@ import { setAuthCredentials, throwErrorMessage, clearLocalStorageOnLogout, + parseAPIErrorResponse, } from 'dashboard/store/utils/api'; import wootAPI from './apiClient'; import { @@ -42,8 +43,9 @@ export const login = async ({ mfaToken: error.response.data.mfa_token, }; } - throwErrorMessage(error); - return null; + const loginError = new Error(parseAPIErrorResponse(error)); + loginError.errorCode = error.response?.data?.error_code; + throw loginError; } }; diff --git a/app/javascript/v3/views/login/Index.vue b/app/javascript/v3/views/login/Index.vue index 23e598dbd..2f8cf70ef 100644 --- a/app/javascript/v3/views/login/Index.vue +++ b/app/javascript/v3/views/login/Index.vue @@ -26,6 +26,7 @@ const ERROR_MESSAGES = { }; const IMPERSONATION_URL_SEARCH_KEY = 'impersonation'; +const USER_NOT_CONFIRMED_ERROR_CODE = 'user_not_confirmed'; export default { components: { @@ -185,6 +186,15 @@ export default { this.showAlertMessage(this.$t('LOGIN.API.SUCCESS_MESSAGE')); }) .catch(response => { + if (response?.errorCode === USER_NOT_CONFIRMED_ERROR_CODE) { + this.loginApi.showLoading = false; + this.$router.push({ + name: 'auth_verify_email', + state: { email: credentials.email }, + }); + return; + } + // Reset URL Params if the authentication is invalid if (this.email) { window.location = '/app/login'; diff --git a/spec/controllers/devise/session_controller_spec.rb b/spec/controllers/devise/session_controller_spec.rb index f9c2ad1fd..dad1d507b 100644 --- a/spec/controllers/devise/session_controller_spec.rb +++ b/spec/controllers/devise/session_controller_spec.rb @@ -16,6 +16,22 @@ RSpec.describe 'Session', type: :request do end end + context 'when the user is unconfirmed' do + let!(:user) { create(:user, password: 'Password1!', account: account, skip_confirmation: false) } + + it 'returns an unconfirmed user error code' do + params = { email: user.email, password: 'Password1!' } + + post new_user_session_url, + params: params, + as: :json + + expect(response).to have_http_status(:unauthorized) + expect(response.parsed_body['error_code']).to eq('user_not_confirmed') + expect(response.parsed_body['errors'].first).to include(user.email) + end + end + context 'when it is valid credentials' do let!(:user) { create(:user, password: 'Password1!', account: account) } let!(:user_with_new_pwd) { create(:user, password: 'Password1!.>