From 761c4885d94ad7d6ded77d2867d02cb5eb329b01 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Thu, 22 Aug 2024 18:17:56 +0530 Subject: [PATCH] refactor: split deserialize function --- lib/integrations/openai_base_service.rb | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/integrations/openai_base_service.rb b/lib/integrations/openai_base_service.rb index c7c28871d..010bfce4f 100644 --- a/lib/integrations/openai_base_service.rb +++ b/lib/integrations/openai_base_service.rb @@ -42,10 +42,13 @@ class Integrations::OpenaiBaseService return nil unless event_is_cacheable? return nil if cache_key.blank? - value_from_cache = Redis::Alfred.get(cache_key) - return nil if value_from_cache.blank? + deserialize_cached_value(Redis::Alfred.get(cache_key)) + end - JSON.parse(value_from_cache, symbolize_names: true) + def deserialize_cached_value(value) + return nil if value.blank? + + JSON.parse(value, symbolize_names: true) rescue JSON::ParserError nil end