From 73fcb91ca39793901d0573193e4043bc7b2dbf7b Mon Sep 17 00:00:00 2001
From: Pranav <pranav@chatwoot.com>
Date: Tue, 13 Feb 2024 14:49:49 -0800
Subject: [PATCH] Update filter properly

---
 .../components/LiveReports/OpenConversations.vue | 16 +++++++++++-----
 .../reports/components/overview/MetricCard.vue   |  2 +-
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/app/javascript/dashboard/routes/dashboard/settings/reports/components/LiveReports/OpenConversations.vue b/app/javascript/dashboard/routes/dashboard/settings/reports/components/LiveReports/OpenConversations.vue
index 958e8e41f..7acb9004f 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/reports/components/LiveReports/OpenConversations.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/reports/components/LiveReports/OpenConversations.vue
@@ -3,6 +3,7 @@ import { mapGetters } from 'vuex';
 import { OVERVIEW_METRICS } from '../../constants';
 import MetricCard from '../overview/MetricCard.vue';
 import MultiselectDropdown from 'shared/components/ui/MultiselectDropdown.vue';
+const noneTeam = { team_id: 0, name: 'All teams' };
 
 export default {
   components: {
@@ -11,7 +12,7 @@ export default {
   },
   data() {
     return {
-      selectedTeam: null,
+      selectedTeam: noneTeam,
     };
   },
   computed: {
@@ -30,13 +31,18 @@ export default {
       });
       return metric;
     },
+    teamsList() {
+      return [noneTeam, ...this.teams];
+    },
   },
   mounted() {
     this.$store.dispatch('fetchLiveConversationMetric');
   },
   methods: {
     onSelectTeam(team) {
-      this.$store.dispatch('fetchLiveConversationMetric', { team_id: team.id });
+      this.$store.dispatch('fetchLiveConversationMetric', {
+        team_id: !team.id ? null : team.id,
+      });
       this.selectedTeam = team;
     },
   },
@@ -46,7 +52,7 @@ export default {
 <template>
   <div class="column small-12 medium-8 conversation-metric">
     <metric-card
-      class="overflow-visible"
+      class="overflow-visible min-h-[150px]"
       :header="$t('OVERVIEW_REPORTS.ACCOUNT_CONVERSATIONS.HEADER')"
       :is-loading="uiFlags.isFetchingAccountConversationMetric"
       loading-message="Loading metrics"
@@ -54,10 +60,10 @@ export default {
       <template #control>
         <multiselect-dropdown
           class="!mb-0 !w-1/2"
-          :options="teams"
+          :options="teamsList"
           :selected-item="selectedTeam"
           multiselector-title=""
-          multiselector-placeholder="Select a team"
+          multiselector-placeholder="All teams"
           no-search-result="No teams found"
           input-placeholder="Search for a team"
           :is-filter="true"
diff --git a/app/javascript/dashboard/routes/dashboard/settings/reports/components/overview/MetricCard.vue b/app/javascript/dashboard/routes/dashboard/settings/reports/components/overview/MetricCard.vue
index c52624442..873cdade1 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/reports/components/overview/MetricCard.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/reports/components/overview/MetricCard.vue
@@ -115,6 +115,6 @@ export default {
 }
 
 .conversation-metric-loader {
-  @apply items-center flex text-base justify-center p-12;
+  @apply items-center flex text-base justify-center;
 }
 </style>