From 6caf7ded2db7ad8fab70941ea538830cd6f29dac Mon Sep 17 00:00:00 2001
From: iamsivin <iamsivin@gmail.com>
Date: Tue, 12 Nov 2024 09:08:21 +0530
Subject: [PATCH] chore: Minor fix

---
 .../Contacts/ContactsCard/ContactsCard.vue        |  5 +----
 .../ContactsSidebar/ContactCustomAttributes.vue   | 15 ++++++---------
 .../dashboard/i18n/locale/en/contact.json         |  1 -
 3 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.vue b/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.vue
index fcdb23ed6..15a812787 100644
--- a/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.vue
+++ b/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.vue
@@ -120,10 +120,7 @@ const onClickViewDetails = async () => {
         leave-from-class="opacity-100 max-h-[360px]"
         leave-to-class="overflow-hidden opacity-0 max-h-0"
       >
-        <div
-          v-show="isExpanded"
-          class="w-full overflow-visible transition-all duration-200"
-        >
+        <div v-show="isExpanded" class="w-full">
           <div class="p-6 border-t border-n-strong">
             <ContactsForm
               :contact-data="{
diff --git a/app/javascript/dashboard/components-next/Contacts/ContactsSidebar/ContactCustomAttributes.vue b/app/javascript/dashboard/components-next/Contacts/ContactsSidebar/ContactCustomAttributes.vue
index 8891ee0bb..1e8a4fb36 100644
--- a/app/javascript/dashboard/components-next/Contacts/ContactsSidebar/ContactCustomAttributes.vue
+++ b/app/javascript/dashboard/components-next/Contacts/ContactsSidebar/ContactCustomAttributes.vue
@@ -78,6 +78,7 @@ const filteredUnusedAttributes = computed(() => {
 });
 
 const unusedAttributesCount = computed(() => unusedAttributes.value?.length);
+const hasNoUnusedAttributes = computed(() => unusedAttributesCount.value === 0);
 </script>
 
 <template>
@@ -90,7 +91,7 @@ const unusedAttributesCount = computed(() => unusedAttributes.value?.length);
         :attribute="attribute"
       />
     </div>
-    <div class="flex items-center gap-3">
+    <div v-if="!hasNoUnusedAttributes" class="flex items-center gap-3">
       <div class="flex-1 h-[1px] bg-n-slate-5" />
       <span class="text-sm font-medium text-n-slate-10">{{
         t('CONTACTS_LAYOUT.SIDEBAR.ATTRIBUTES.UNUSED_ATTRIBUTES', {
@@ -99,7 +100,7 @@ const unusedAttributesCount = computed(() => unusedAttributes.value?.length);
       }}</span>
       <div class="flex-1 h-[1px] bg-n-slate-5" />
     </div>
-    <div class="relative">
+    <div v-if="!hasNoUnusedAttributes" class="relative">
       <span class="absolute i-lucide-search size-3.5 top-2 left-3" />
       <input
         v-model="searchQuery"
@@ -110,16 +111,12 @@ const unusedAttributesCount = computed(() => unusedAttributes.value?.length);
         class="w-full h-8 py-2 pl-10 pr-2 text-sm border-none rounded-xl bg-n-solid-1 text-n-slate-12"
       />
     </div>
-    <div v-if="filteredUnusedAttributes.length === 0">
+    <div v-if="filteredUnusedAttributes.length === 0 && !hasNoUnusedAttributes">
       <p class="text-sm text-n-slate-11">
-        {{
-          unusedAttributesCount === 0
-            ? t('CONTACTS_LAYOUT.SIDEBAR.ATTRIBUTES.EMPTY_STATE')
-            : t('CONTACTS_LAYOUT.SIDEBAR.ATTRIBUTES.NO_ATTRIBUTES')
-        }}
+        {{ t('CONTACTS_LAYOUT.SIDEBAR.ATTRIBUTES.EMPTY_STATE') }}
       </p>
     </div>
-    <div class="flex flex-col gap-2">
+    <div v-if="!hasNoUnusedAttributes" class="flex flex-col gap-2">
       <ContactCustomAttributeItem
         v-for="attribute in filteredUnusedAttributes"
         :key="attribute.id"
diff --git a/app/javascript/dashboard/i18n/locale/en/contact.json b/app/javascript/dashboard/i18n/locale/en/contact.json
index 7727c871f..e7578b3d7 100644
--- a/app/javascript/dashboard/i18n/locale/en/contact.json
+++ b/app/javascript/dashboard/i18n/locale/en/contact.json
@@ -572,7 +572,6 @@
           "INVALID_DATE": "Invalid date"
         },
         "NO_ATTRIBUTES": "No attributes found",
-        "EMPTY_STATE": "No unused attributes found",
         "API": {
           "SUCCESS_MESSAGE": "Attribute updated successfully",
           "DELETE_SUCCESS_MESSAGE": "Attribute deleted successfully",