From 6b86b6f87de72c232eddbe09b3bb17e83a5bb1ee Mon Sep 17 00:00:00 2001
From: Muhsin Keloth <muhsinkeramam@gmail.com>
Date: Mon, 20 May 2024 10:55:00 +0530
Subject: [PATCH] chore: refactor link issue related components

---
 .../widgets/conversation/linear/LinkIssue.vue | 60 +++++++++----------
 .../conversation/linear/SearchIssue.vue       |  1 -
 .../linear/SearchListDropdown.vue             |  7 +--
 .../conversation/linear/validations.js        |  1 +
 4 files changed, 31 insertions(+), 38 deletions(-)

diff --git a/app/javascript/dashboard/components/widgets/conversation/linear/LinkIssue.vue b/app/javascript/dashboard/components/widgets/conversation/linear/LinkIssue.vue
index dd66df228..22150a95a 100644
--- a/app/javascript/dashboard/components/widgets/conversation/linear/LinkIssue.vue
+++ b/app/javascript/dashboard/components/widgets/conversation/linear/LinkIssue.vue
@@ -7,12 +7,12 @@
     >
       <template v-if="shouldShowDropdown" #dropdown>
         <search-list-dropdown
-          v-if="items"
+          v-if="issues"
           v-on-clickaway="toggleDropdown"
-          :items="items"
+          :items="issues"
           :selected-id="selectedOption.id"
           class="flex flex-col w-[240px] overflow-y-auto left-0 md:left-auto md:right-0 top-10"
-          @on-search="handleSearchChange"
+          @on-search="onSearch"
           @click="onSelectIssue"
         />
       </template>
@@ -35,13 +35,14 @@
     </div>
   </div>
 </template>
+
 <script setup>
-import LinearAPI from 'dashboard/api/integrations/linear';
-import { useAlert } from 'dashboard/composables';
+import { ref, computed } from 'vue';
 import { useI18n } from 'dashboard/composables/useI18n';
-import { computed, ref } from 'vue';
-import SearchListDropdown from './SearchListDropdown.vue';
+import { useAlert } from 'dashboard/composables';
+import LinearAPI from 'dashboard/api/integrations/linear';
 import SearchIssue from './SearchIssue.vue';
+import SearchListDropdown from './SearchListDropdown.vue';
 
 const props = defineProps({
   conversationId: {
@@ -49,27 +50,30 @@ const props = defineProps({
     required: true,
   },
 });
-const { t } = useI18n();
-const items = ref([]);
-const shouldShowDropdown = ref(false);
-const toggleDropdown = () => {
-  items.value = [];
-  shouldShowDropdown.value = !shouldShowDropdown.value;
-};
 
-const selectedOption = ref({
-  id: null,
-  name: '',
-});
+const emits = defineEmits(['close']);
+
+const { t } = useI18n();
+const issues = ref([]);
+const shouldShowDropdown = ref(false);
+const selectedOption = ref({ id: null, name: '' });
 const isFetching = ref(false);
 const isLinking = ref(false);
 const searchQuery = ref('');
 
+const toggleDropdown = () => {
+  issues.value = [];
+  shouldShowDropdown.value = !shouldShowDropdown.value;
+};
+
 const linkIssueTitle = computed(() => {
-  if (selectedOption.value.id) {
-    return selectedOption.value.name;
-  }
-  return t('INTEGRATION_SETTINGS.LINEAR.LINK.SELECT');
+  return selectedOption.value.id
+    ? selectedOption.value.name
+    : t('INTEGRATION_SETTINGS.LINEAR.LINK.SELECT');
+});
+
+const isSubmitDisabled = computed(() => {
+  return !selectedOption.value.id || isLinking.value;
 });
 
 const onSelectIssue = item => {
@@ -77,23 +81,17 @@ const onSelectIssue = item => {
   toggleDropdown();
 };
 
-const isSubmitDisabled = computed(() => {
-  return !selectedOption.value.id || isLinking.value;
-});
-
-const emits = defineEmits(['close']);
-
 const onClose = () => {
   emits('close');
 };
 
-const handleSearchChange = async value => {
+const onSearch = async value => {
   if (!value) return;
   searchQuery.value = value;
   try {
     isFetching.value = true;
     const response = await LinearAPI.searchIssues(value);
-    items.value = response.data.map(issue => ({
+    issues.value = response.data.map(issue => ({
       id: issue.id,
       name: `${issue.identifier} ${issue.title}`,
     }));
@@ -111,7 +109,7 @@ const linkIssue = async () => {
     await LinearAPI.link_issue(props.conversationId, issueId);
     useAlert(t('INTEGRATION_SETTINGS.LINEAR.LINK.LINK_SUCCESS'));
     searchQuery.value = '';
-    items.value = [];
+    issues.value = [];
     onClose();
   } catch (error) {
     useAlert(t('INTEGRATION_SETTINGS.LINEAR.LINK.LINK_ERROR'));
diff --git a/app/javascript/dashboard/components/widgets/conversation/linear/SearchIssue.vue b/app/javascript/dashboard/components/widgets/conversation/linear/SearchIssue.vue
index 0d86127f9..c57c1a22f 100644
--- a/app/javascript/dashboard/components/widgets/conversation/linear/SearchIssue.vue
+++ b/app/javascript/dashboard/components/widgets/conversation/linear/SearchIssue.vue
@@ -21,6 +21,5 @@ defineProps({
       size="18"
       class="flex-shrink-0 text-slate-900 dark:text-slate-50"
     />
-    <slot name="dropdown" />
   </button>
 </template>
diff --git a/app/javascript/dashboard/components/widgets/conversation/linear/SearchListDropdown.vue b/app/javascript/dashboard/components/widgets/conversation/linear/SearchListDropdown.vue
index da657a8a9..c8a13da0e 100644
--- a/app/javascript/dashboard/components/widgets/conversation/linear/SearchListDropdown.vue
+++ b/app/javascript/dashboard/components/widgets/conversation/linear/SearchListDropdown.vue
@@ -31,11 +31,6 @@ const filteredItems = computed(() => {
 const isListEmpty = computed(() => {
   return !filteredItems.value.length;
 });
-
-const isActive = id => {
-  if (!props.selectedId) return false;
-  return id === props.selectedId;
-};
 </script>
 <template>
   <div
@@ -53,7 +48,7 @@ const isActive = id => {
     <search-issue-item
       v-for="item in filteredItems"
       :key="item.id"
-      :is-active="isActive(item.id)"
+      :is-active="item.id === selectedId"
       :button-text="item.name"
       @click="$emit('click', item)"
     />
diff --git a/app/javascript/dashboard/components/widgets/conversation/linear/validations.js b/app/javascript/dashboard/components/widgets/conversation/linear/validations.js
index f1bb06baf..d30b790a7 100644
--- a/app/javascript/dashboard/components/widgets/conversation/linear/validations.js
+++ b/app/javascript/dashboard/components/widgets/conversation/linear/validations.js
@@ -1,4 +1,5 @@
 import { required } from '@vuelidate/validators';
+
 export default {
   title: {
     required,