review changes

This commit is contained in:
Tanmay Deep Sharma
2025-11-12 17:59:52 +05:30
parent 3c7b4f6011
commit 44da47c845
7 changed files with 29 additions and 22 deletions
@@ -2,7 +2,7 @@ class AutoAssignment::AssignmentService
pattr_initialize [:inbox!]
def perform_bulk_assignment(limit: 100)
return 0 unless inbox.enable_auto_assignment
return 0 unless inbox.auto_assignment_v2_enabled?
assigned_count = 0
@@ -32,10 +32,10 @@ class AutoAssignment::AssignmentService
def unassigned_conversations(limit)
scope = inbox.conversations.unassigned.open
scope = if assignment_config['conversation_priority'] == 'longest_waiting'
scope.order(last_activity_at: :asc, created_at: :asc)
scope = if assignment_config['conversation_priority'].to_s == 'longest_waiting'
scope.reorder(last_activity_at: :asc, created_at: :asc)
else
scope.order(created_at: :asc)
scope.reorder(created_at: :asc)
end
scope.limit(limit)
+2 -2
View File
@@ -40,10 +40,10 @@ class AutoAssignment::RateLimiter
end
def assignment_key_pattern
"assignment:#{inbox.id}:agent:#{agent.id}:*"
format(Redis::RedisKeys::ASSIGNMENT_KEY_PATTERN, inbox_id: inbox.id, agent_id: agent.id)
end
def build_assignment_key(conversation_id)
"assignment:#{inbox.id}:agent:#{agent.id}:conversation:#{conversation_id}"
format(Redis::RedisKeys::ASSIGNMENT_KEY, inbox_id: inbox.id, agent_id: agent.id, conversation_id: conversation_id)
end
end