From 525a979283c67f6f2381d161be029e0935259b6c Mon Sep 17 00:00:00 2001 From: iamsivin Date: Thu, 21 Nov 2024 00:08:03 +0530 Subject: [PATCH 1/4] chore: Minor fix --- .../ContactsCard/ContactsCard.story.vue | 216 ++++++++++++++++++ .../Contacts/ContactsCard/ContactsCard.vue | 40 +--- .../ContactsForm/ContactsForm.story.vue | 101 ++++++++ .../Contacts/ContactsForm/ContactsForm.vue | 2 +- .../Contacts/Pages/ContactsList.vue | 42 ++++ 5 files changed, 364 insertions(+), 37 deletions(-) create mode 100644 app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.story.vue create mode 100644 app/javascript/dashboard/components-next/Contacts/ContactsForm/ContactsForm.story.vue diff --git a/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.story.vue b/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.story.vue new file mode 100644 index 000000000..8b06bf4e1 --- /dev/null +++ b/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.story.vue @@ -0,0 +1,216 @@ + + + diff --git a/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.vue b/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.vue index 48195248d..3bad3f9f7 100644 --- a/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.vue +++ b/app/javascript/dashboard/components-next/Contacts/ContactsCard/ContactsCard.vue @@ -1,8 +1,5 @@ diff --git a/app/javascript/dashboard/components-next/Contacts/ContactsForm/ContactsForm.story.vue b/app/javascript/dashboard/components-next/Contacts/ContactsForm/ContactsForm.story.vue new file mode 100644 index 000000000..35d36837f --- /dev/null +++ b/app/javascript/dashboard/components-next/Contacts/ContactsForm/ContactsForm.story.vue @@ -0,0 +1,101 @@ + + + diff --git a/app/javascript/dashboard/components-next/Contacts/ContactsForm/ContactsForm.vue b/app/javascript/dashboard/components-next/Contacts/ContactsForm/ContactsForm.vue index 7551fa8fc..5ee6c996e 100644 --- a/app/javascript/dashboard/components-next/Contacts/ContactsForm/ContactsForm.vue +++ b/app/javascript/dashboard/components-next/Contacts/ContactsForm/ContactsForm.vue @@ -81,7 +81,7 @@ const validationRules = { const v$ = useVuelidate(validationRules, state); const updateState = () => { - if (props.isNewContact) return; + if (props.isNewContact) return; // Added to prevent state update for new contact form const { id, name = '', diff --git a/app/javascript/dashboard/components-next/Contacts/Pages/ContactsList.vue b/app/javascript/dashboard/components-next/Contacts/Pages/ContactsList.vue index e02e72b4b..8e94884bd 100644 --- a/app/javascript/dashboard/components-next/Contacts/Pages/ContactsList.vue +++ b/app/javascript/dashboard/components-next/Contacts/Pages/ContactsList.vue @@ -1,5 +1,8 @@ + + From e3f50da277cdbddfe98b5d650d9278d1694906c1 Mon Sep 17 00:00:00 2001 From: iamsivin Date: Thu, 21 Nov 2024 00:37:12 +0530 Subject: [PATCH 3/4] chore: Minor fix --- .../CustomAttributes/CustomAttributes.story.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/javascript/dashboard/components-next/CustomAttributes/CustomAttributes.story.vue b/app/javascript/dashboard/components-next/CustomAttributes/CustomAttributes.story.vue index 9c8808e1f..3246002fc 100644 --- a/app/javascript/dashboard/components-next/CustomAttributes/CustomAttributes.story.vue +++ b/app/javascript/dashboard/components-next/CustomAttributes/CustomAttributes.story.vue @@ -75,7 +75,7 @@ const handleDelete = type => {
@@ -99,7 +99,7 @@ const handleDelete = type => {
From 257a5ccf83623d94876217f283d3fa28dfcde082 Mon Sep 17 00:00:00 2001 From: iamsivin Date: Thu, 21 Nov 2024 00:42:01 +0530 Subject: [PATCH 4/4] chore: Minor fix --- .../components-next/CustomAttributes/ListAttribute.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/javascript/dashboard/components-next/CustomAttributes/ListAttribute.vue b/app/javascript/dashboard/components-next/CustomAttributes/ListAttribute.vue index ac931caf9..675023288 100644 --- a/app/javascript/dashboard/components-next/CustomAttributes/ListAttribute.vue +++ b/app/javascript/dashboard/components-next/CustomAttributes/ListAttribute.vue @@ -72,8 +72,8 @@ const handleAttributeAction = async action => { show-search class="w-48 mt-2 top-full" :class="{ - 'right-0': !isEditingView, - 'left-0': isEditingView, + 'ltr:right-0 rtl:left-0': !isEditingView, + 'ltr:left-0 rtl:right-0': isEditingView, }" @action="handleAttributeAction($event)" />