From 17f5112015aa4dc80d9e402b85f234b1cf1a9b90 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Fri, 13 Feb 2026 12:44:03 +0530 Subject: [PATCH] fix: skip per-metric rollup check in summary builders Summary builders fetch all metrics in a single query and don't use params[:metric], so metric_covered? was always returning false and preventing rollup usage for summary reports. --- app/builders/v2/reports/base_summary_builder.rb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/builders/v2/reports/base_summary_builder.rb b/app/builders/v2/reports/base_summary_builder.rb index a9cea3d79..a3aa4fb14 100644 --- a/app/builders/v2/reports/base_summary_builder.rb +++ b/app/builders/v2/reports/base_summary_builder.rb @@ -9,6 +9,12 @@ class V2::Reports::BaseSummaryBuilder private + # Summary builders fetch all metrics in a single query, so the per-metric + # check from RollupConditions does not apply. + def metric_covered? + true + end + def load_data @conversations_count = fetch_conversations_count use_rollup? ? load_rollup_data : load_reporting_events_data