From 16bc70b6dc2af5c5f20e8c87df1a0e681cf1d566 Mon Sep 17 00:00:00 2001 From: iamsivin Date: Fri, 26 Jul 2024 12:34:36 +0530 Subject: [PATCH] fix: apply ESLint rule vue/prefer-true-attribute-shorthand --- .eslintrc.js | 1 + .../dashboard/components/ConversationItem.vue | 2 +- .../layout/sidebarComponents/Primary.vue | 2 +- .../dashboard/components/ui/DateRangePicker.vue | 4 ++-- .../dashboard/components/ui/DateTimePicker.vue | 2 +- .../components/widgets/AutomationActionInput.vue | 4 ++-- .../widgets/AutomationActionTeamMessageInput.vue | 2 +- .../dashboard/components/widgets/ColorPicker.vue | 2 +- .../components/widgets/FilterInput/Index.vue | 2 +- .../dashboard/components/widgets/LabelSelector.vue | 2 +- .../components/widgets/ThumbnailGroup.vue | 2 +- .../conversation/ConversationAdvancedFilter.vue | 2 +- .../components/widgets/conversation/ReplyBox.vue | 8 ++++---- .../widgets/conversation/bubble/Image.vue | 2 +- .../modules/contact/components/ContactFields.vue | 8 ++++---- .../modules/contact/components/MergeContact.vue | 2 +- .../routes/dashboard/commands/commandbar.vue | 2 +- .../components/ContactsAdvancedFilters.vue | 2 +- .../contacts/components/ContactsTable.vue | 2 +- .../conversation/ContactConversations.vue | 2 +- .../conversation/ConversationParticipant.vue | 14 +++++++------- .../dashboard/conversation/contact/ContactForm.vue | 2 +- .../conversation/contact/ConversationForm.vue | 10 +++++----- .../customAttributes/CustomAttributes.vue | 2 +- .../dashboard/conversation/labels/LabelBox.vue | 2 +- .../helpcenter/components/PortalListItemTable.vue | 2 +- .../helpcenter/pages/articles/ArticleSettings.vue | 4 ++-- .../helpcenter/pages/categories/NameEmojiInput.vue | 2 +- .../dashboard/settings/attributes/AddAttribute.vue | 4 ++-- .../settings/attributes/EditAttribute.vue | 4 ++-- .../dashboard/settings/campaigns/AddCampaign.vue | 4 ++-- .../dashboard/settings/campaigns/EditCampaign.vue | 2 +- .../routes/dashboard/settings/canned/AddCanned.vue | 2 +- .../dashboard/settings/canned/EditCanned.vue | 2 +- .../routes/dashboard/settings/inbox/AddAgents.vue | 4 ++-- .../dashboard/settings/inbox/channels/Facebook.vue | 4 ++-- .../inbox/components/WeeklyAvailability.vue | 10 +++++----- .../inbox/settingsPage/CollaboratorsPage.vue | 4 ++-- .../inbox/settingsPage/ConfigurationPage.vue | 2 +- .../routes/dashboard/settings/macros/MacroNode.vue | 2 +- .../settings/profile/MessageSignature.vue | 4 ++-- .../dashboard/settings/reports/BotReports.vue | 2 +- .../dashboard/settings/reports/CsatResponses.vue | 6 +++--- .../routes/dashboard/settings/reports/Index.vue | 2 +- .../settings/reports/components/CsatTable.vue | 4 ++-- .../settings/reports/components/Filters/Agents.vue | 4 ++-- .../reports/components/overview/AgentTable.vue | 2 +- .../shared/components/GreetingsEditor.vue | 8 ++++---- .../shared/components/emoji/EmojiInput.vue | 2 +- 49 files changed, 86 insertions(+), 85 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 2239542f0..fe5cb8d79 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -150,6 +150,7 @@ module.exports = { 'vue/no-unused-emit-declarations': 'error', 'vue/no-unused-refs': 'error', 'vue/no-use-v-else-with-v-for': 'error', + 'vue/prefer-true-attribute-shorthand': 'error', 'vue/no-useless-v-bind': [ 'error', { diff --git a/app/javascript/dashboard/components/ConversationItem.vue b/app/javascript/dashboard/components/ConversationItem.vue index 53ddfc164..55721ac21 100644 --- a/app/javascript/dashboard/components/ConversationItem.vue +++ b/app/javascript/dashboard/components/ConversationItem.vue @@ -58,7 +58,7 @@ export default { :conversation-type="conversationType" :selected="isConversationSelected(source.id)" :show-assignee="showAssignee" - :enable-context-menu="true" + enable-context-menu @selectConversation="selectConversation" @deSelectConversation="deSelectConversation" @assignAgent="assignAgent" diff --git a/app/javascript/dashboard/components/layout/sidebarComponents/Primary.vue b/app/javascript/dashboard/components/layout/sidebarComponents/Primary.vue index 26161fbc3..12edff7c0 100644 --- a/app/javascript/dashboard/components/layout/sidebarComponents/Primary.vue +++ b/app/javascript/dashboard/components/layout/sidebarComponents/Primary.vue @@ -92,7 +92,7 @@ export default { v-if="!isACustomBrandedInstance" icon="book-open-globe" name="DOCS" - :open-in-new-page="true" + open-in-new-page :to="helpDocsURL" /> diff --git a/app/javascript/dashboard/components/ui/DateRangePicker.vue b/app/javascript/dashboard/components/ui/DateRangePicker.vue index bb87a8d92..7787ab83d 100644 --- a/app/javascript/dashboard/components/ui/DateRangePicker.vue +++ b/app/javascript/dashboard/components/ui/DateRangePicker.vue @@ -27,8 +27,8 @@ export default {