From 13b28b5db9175937a3453b72cd499633d52305aa Mon Sep 17 00:00:00 2001
From: Fayaz Ahmed <fayazara@gmail.com>
Date: Tue, 3 Sep 2024 00:50:52 +0530
Subject: [PATCH] Review fixes

---
 .../composables/specs => composables/spec}/usePortal.spec.js | 0
 .../dashboard/helpcenter => }/composables/usePortal.js       | 5 +++--
 .../routes/dashboard/helpcenter/components/ArticleItem.vue   | 2 +-
 .../helpcenter/components/ArticleSearch/SearchPopover.vue    | 2 +-
 .../dashboard/helpcenter/components/HelpCenterLayout.vue     | 2 +-
 .../dashboard/helpcenter/components/PortalListItemTable.vue  | 2 +-
 .../routes/dashboard/helpcenter/components/PortalSwitch.vue  | 2 +-
 .../dashboard/helpcenter/pages/articles/EditArticle.vue      | 2 +-
 .../dashboard/helpcenter/pages/articles/NewArticle.vue       | 2 +-
 9 files changed, 10 insertions(+), 9 deletions(-)
 rename app/javascript/dashboard/{routes/dashboard/helpcenter/composables/specs => composables/spec}/usePortal.spec.js (100%)
 rename app/javascript/dashboard/{routes/dashboard/helpcenter => }/composables/usePortal.js (91%)

diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/composables/specs/usePortal.spec.js b/app/javascript/dashboard/composables/spec/usePortal.spec.js
similarity index 100%
rename from app/javascript/dashboard/routes/dashboard/helpcenter/composables/specs/usePortal.spec.js
rename to app/javascript/dashboard/composables/spec/usePortal.spec.js
diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/composables/usePortal.js b/app/javascript/dashboard/composables/usePortal.js
similarity index 91%
rename from app/javascript/dashboard/routes/dashboard/helpcenter/composables/usePortal.js
rename to app/javascript/dashboard/composables/usePortal.js
index 567b42749..807bfe15b 100644
--- a/app/javascript/dashboard/routes/dashboard/helpcenter/composables/usePortal.js
+++ b/app/javascript/dashboard/composables/usePortal.js
@@ -19,8 +19,9 @@ import { computed } from 'vue';
  */
 export const usePortal = () => {
   const { accountId } = useAccount();
-  const portalSlug = computed(() => useRoute().params.portalSlug);
-  const locale = computed(() => useRoute().params.locale);
+  const route = useRoute();
+  const portalSlug = computed(() => route.params.portalSlug);
+  const locale = computed(() => route.params.locale);
 
   /**
    * Generates the URL for an article.
diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleItem.vue b/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleItem.vue
index 73378299e..ba03e28f0 100644
--- a/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleItem.vue
+++ b/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleItem.vue
@@ -1,6 +1,6 @@
 <script>
 import { dynamicTime } from 'shared/helpers/timeHelper';
-import { usePortal } from '../composables/usePortal';
+import { usePortal } from 'dashboard/composables/usePortal';
 import { frontendURL } from 'dashboard/helper/URLHelper';
 import Thumbnail from 'dashboard/components/widgets/Thumbnail.vue';
 import { useAccount } from 'dashboard/composables/useAccount';
diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleSearch/SearchPopover.vue b/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleSearch/SearchPopover.vue
index 71739c22b..7bf82383f 100644
--- a/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleSearch/SearchPopover.vue
+++ b/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleSearch/SearchPopover.vue
@@ -7,7 +7,7 @@ import SearchResults from './SearchResults.vue';
 import ArticleView from './ArticleView.vue';
 import ArticlesAPI from 'dashboard/api/helpCenter/articles';
 import { buildPortalArticleURL } from 'dashboard/helper/portalHelper';
-import { usePortal } from '../../composables/usePortal';
+import { usePortal } from 'dashboard/composables/usePortal';
 
 export default {
   name: 'ArticleSearchPopover',
diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/components/HelpCenterLayout.vue b/app/javascript/dashboard/routes/dashboard/helpcenter/components/HelpCenterLayout.vue
index a17698140..4df116b6d 100644
--- a/app/javascript/dashboard/routes/dashboard/helpcenter/components/HelpCenterLayout.vue
+++ b/app/javascript/dashboard/routes/dashboard/helpcenter/components/HelpCenterLayout.vue
@@ -11,7 +11,7 @@ import AccountSelector from 'dashboard/components/layout/sidebarComponents/Accou
 import NotificationPanel from 'dashboard/routes/dashboard/notifications/components/NotificationPanel.vue';
 import { useUISettings } from 'dashboard/composables/useUISettings';
 import { useAccount } from 'dashboard/composables/useAccount';
-import { usePortal } from '../composables/usePortal';
+import { usePortal } from 'dashboard/composables/usePortal';
 import AddCategory from '../pages/categories/AddCategory.vue';
 import { FEATURE_FLAGS } from 'dashboard/featureFlags';
 const CommandBar = () =>
diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalListItemTable.vue b/app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalListItemTable.vue
index e04410760..268023e03 100644
--- a/app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalListItemTable.vue
+++ b/app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalListItemTable.vue
@@ -1,5 +1,5 @@
 <script>
-import { usePortal } from '../composables/usePortal';
+import { usePortal } from 'dashboard/composables/usePortal';
 export default {
   props: {
     locales: {
diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalSwitch.vue b/app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalSwitch.vue
index fd7c0c50b..e10a52121 100644
--- a/app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalSwitch.vue
+++ b/app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalSwitch.vue
@@ -1,6 +1,6 @@
 <script>
 import Thumbnail from 'dashboard/components/widgets/Thumbnail.vue';
-import { usePortal } from '../composables/usePortal';
+import { usePortal } from 'dashboard/composables/usePortal';
 
 export default {
   components: {
diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/pages/articles/EditArticle.vue b/app/javascript/dashboard/routes/dashboard/helpcenter/pages/articles/EditArticle.vue
index 0780c4d53..34f4379ae 100644
--- a/app/javascript/dashboard/routes/dashboard/helpcenter/pages/articles/EditArticle.vue
+++ b/app/javascript/dashboard/routes/dashboard/helpcenter/pages/articles/EditArticle.vue
@@ -5,7 +5,7 @@ import EditArticleHeader from '../../components/Header/EditArticleHeader.vue';
 import ArticleEditor from '../../components/ArticleEditor.vue';
 import ArticleSettings from './ArticleSettings.vue';
 import Spinner from 'shared/components/Spinner.vue';
-import { usePortal } from '../../composables/usePortal';
+import { usePortal } from 'dashboard/composables/usePortal';
 import wootConstants from 'dashboard/constants/globals';
 import { buildPortalArticleURL } from 'dashboard/helper/portalHelper';
 import { PORTALS_EVENTS } from '../../../../../helper/AnalyticsHelper/events';
diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/pages/articles/NewArticle.vue b/app/javascript/dashboard/routes/dashboard/helpcenter/pages/articles/NewArticle.vue
index 897e589a5..6c7bf4705 100644
--- a/app/javascript/dashboard/routes/dashboard/helpcenter/pages/articles/NewArticle.vue
+++ b/app/javascript/dashboard/routes/dashboard/helpcenter/pages/articles/NewArticle.vue
@@ -3,7 +3,7 @@ import { mapGetters } from 'vuex';
 import { useAlert } from 'dashboard/composables';
 import EditArticleHeader from 'dashboard/routes/dashboard/helpcenter/components/Header/EditArticleHeader.vue';
 import ArticleEditor from '../../components/ArticleEditor.vue';
-import { usePortal } from '../../composables/usePortal';
+import { usePortal } from 'dashboard/composables/usePortal';
 import ArticleSettings from './ArticleSettings.vue';
 import { PORTALS_EVENTS } from '../../../../../helper/AnalyticsHelper/events';
 export default {