From 1180c9e8b683628d46df8f3dc9bda4e5a924a7d3 Mon Sep 17 00:00:00 2001 From: iamsivin Date: Mon, 23 Feb 2026 23:28:52 +0530 Subject: [PATCH] chore: Review fix --- .../dashboard/helper/snoozeDateParser/localization.js | 4 ++-- app/javascript/dashboard/helper/snoozeHelpers.js | 7 ++++++- .../dashboard/routes/dashboard/commands/commandbar.vue | 6 +----- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/app/javascript/dashboard/helper/snoozeDateParser/localization.js b/app/javascript/dashboard/helper/snoozeDateParser/localization.js index 08b5697fe..df3d16c6d 100644 --- a/app/javascript/dashboard/helper/snoozeDateParser/localization.js +++ b/app/javascript/dashboard/helper/snoozeDateParser/localization.js @@ -359,7 +359,7 @@ export const generateDateSuggestions = ( const exact = directParse || parseDateFromText(englishInput, referenceDate); if (exact) { seen.add(exact.unix); - results.push({ label: normalized, ...exact }); + results.push({ label: normalized, query: englishInput, ...exact }); } buildSuggestionCandidates(englishInput).some(candidate => { @@ -371,7 +371,7 @@ export const generateDateSuggestions = ( !useEnglish && pairs.length ? reverseTokens(candidate, pairs) : candidate; - results.push({ label, ...result }); + results.push({ label, query: candidate, ...result }); } return false; }); diff --git a/app/javascript/dashboard/helper/snoozeHelpers.js b/app/javascript/dashboard/helper/snoozeHelpers.js index e4623fcc2..f18100db4 100644 --- a/app/javascript/dashboard/helper/snoozeHelpers.js +++ b/app/javascript/dashboard/helper/snoozeHelpers.js @@ -13,7 +13,10 @@ import { setSeconds, } from 'date-fns'; import wootConstants from 'dashboard/constants/globals'; -import { generateDateSuggestions } from 'dashboard/helper/snoozeDateParser'; +import { + generateDateSuggestions, + parseDateFromText, +} from 'dashboard/helper/snoozeDateParser'; const SNOOZE_OPTIONS = wootConstants.SNOOZE_OPTIONS; @@ -98,8 +101,10 @@ export const generateSnoozeSuggestions = ( return suggestions.map(s => ({ date: s.date, unixTime: s.unix, + query: s.query, label: capitalizeLabel(s.label), formattedDate: formatSnoozeDate(s.date, currentDate, locale), + resolve: () => parseDateFromText(s.query)?.unix ?? s.unix, })); }; diff --git a/app/javascript/dashboard/routes/dashboard/commands/commandbar.vue b/app/javascript/dashboard/routes/dashboard/commands/commandbar.vue index ccd175321..9ea74f624 100644 --- a/app/javascript/dashboard/routes/dashboard/commands/commandbar.vue +++ b/app/javascript/dashboard/routes/dashboard/commands/commandbar.vue @@ -13,7 +13,6 @@ import { useConversationHotKeys } from 'dashboard/composables/commands/useConver import wootConstants from 'dashboard/constants/globals'; import { GENERAL_EVENTS } from 'dashboard/helper/AnalyticsHelper/events'; import { generateSnoozeSuggestions } from 'dashboard/helper/snoozeHelpers'; -import { parseDateFromText } from 'dashboard/helper/snoozeDateParser'; import { ICON_SNOOZE_CONVERSATION } from 'dashboard/helper/commandbar/icons'; import { CMD_SNOOZE_CONVERSATION, @@ -108,10 +107,7 @@ const buildDynamicSnoozeActions = (search, parentId) => { section, icon: ICON_SNOOZE_CONVERSATION, keywords: search, - handler: () => { - const fresh = parseDateFromText(parsed.label.toLowerCase()); - emitter.emit(busEvent, fresh?.unix ?? parsed.unixTime); - }, + handler: () => emitter.emit(busEvent, parsed.resolve()), })); };