From 1154f9ccb436a8ec4d530c010d8da58054b2594e Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Mon, 16 Mar 2026 12:31:33 +0530
Subject: [PATCH] chore: remove prompt enable outside resuce

---
 lib/tasks/reporting_events_rollup.rake         |  3 ++-
 .../reporting_events_rollup_backfill_spec.rb   | 18 ++++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/lib/tasks/reporting_events_rollup.rake b/lib/tasks/reporting_events_rollup.rake
index e21442cbb..c54b155a5 100644
--- a/lib/tasks/reporting_events_rollup.rake
+++ b/lib/tasks/reporting_events_rollup.rake
@@ -187,9 +187,10 @@ class ReportingEventsRollupBackfill # rubocop:disable Metrics/ClassLength
     end
 
     print_success(account, days_processed, total_days, Time.current - start_time)
-    prompt_enable_rollup_read_path(account)
   rescue StandardError => e
     print_failure(e, days_processed, total_days)
+  else
+    prompt_enable_rollup_read_path(account)
   end
 
   def print_success(account, days_processed, _total_days, elapsed_time)
diff --git a/spec/lib/reporting_events_rollup_backfill_spec.rb b/spec/lib/reporting_events_rollup_backfill_spec.rb
index 59ccd1c2a..58128a305 100644
--- a/spec/lib/reporting_events_rollup_backfill_spec.rb
+++ b/spec/lib/reporting_events_rollup_backfill_spec.rb
@@ -31,6 +31,16 @@ describe ReportingEventsRollupBackfill do
         service.send(:execute_backfill, account, date, date, 1)
       end.to raise_error(SystemExit)
     end
+
+    it 'does not report the backfill as failed when enabling the read path fails' do
+      allow(service).to receive(:print_success)
+      allow(service).to receive(:print_failure)
+      allow(service).to receive(:prompt_enable_rollup_read_path).and_raise(StandardError, 'toggle failed')
+
+      expect do
+        service.send(:execute_backfill, account, date, date, 1)
+      end.to raise_error(StandardError, 'toggle failed')
+    end
   end
 
   describe '#prompt_enable_rollup_read_path' do
@@ -49,5 +59,13 @@ describe ReportingEventsRollupBackfill do
 
       service.send(:prompt_enable_rollup_read_path, account)
     end
+
+    it 'skips the prompt when the feature is already enabled' do
+      allow(account).to receive(:feature_enabled?).with(:reporting_events_rollup).and_return(true)
+
+      expect($stdin).not_to receive(:gets)
+
+      service.send(:prompt_enable_rollup_read_path, account)
+    end
   end
 end