From 063d2162471d015410715baf5de9f26391e5a096 Mon Sep 17 00:00:00 2001 From: iamsivin Date: Fri, 26 Jul 2024 02:01:23 +0530 Subject: [PATCH] fix: apply ESLint rule vue/no-required-prop-with-default --- .eslintrc.js | 6 ++++++ .../dashboard/components/widgets/TableHeaderCell.vue | 1 - .../dashboard/modules/widget-preview/components/Widget.vue | 1 - .../routes/dashboard/helpcenter/components/ArticleItem.vue | 1 - .../dashboard/settings/inbox/components/BusinessDay.vue | 1 - 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 6711b06b3..a45c4370f 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -110,6 +110,12 @@ module.exports = { ], 'vue/no-empty-component-block': 'error', 'vue/no-multiple-objects-in-class': 'error', + 'vue/no-required-prop-with-default': [ + 'error', + { + autofix: false, + }, + ], 'vue/max-attributes-per-line': [ 'error', { diff --git a/app/javascript/dashboard/components/widgets/TableHeaderCell.vue b/app/javascript/dashboard/components/widgets/TableHeaderCell.vue index 8e2cd6326..192467dec 100644 --- a/app/javascript/dashboard/components/widgets/TableHeaderCell.vue +++ b/app/javascript/dashboard/components/widgets/TableHeaderCell.vue @@ -8,7 +8,6 @@ const props = defineProps({ label: { type: String, required: true, - default: '', }, }); diff --git a/app/javascript/dashboard/modules/widget-preview/components/Widget.vue b/app/javascript/dashboard/modules/widget-preview/components/Widget.vue index 481cb0137..ce1277c85 100644 --- a/app/javascript/dashboard/modules/widget-preview/components/Widget.vue +++ b/app/javascript/dashboard/modules/widget-preview/components/Widget.vue @@ -26,7 +26,6 @@ export default { }, websiteName: { type: String, - default: '', required: true, }, logo: { diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleItem.vue b/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleItem.vue index 75ea71164..18281aec3 100644 --- a/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleItem.vue +++ b/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleItem.vue @@ -20,7 +20,6 @@ export default { }, title: { type: String, - default: '', required: true, }, author: { diff --git a/app/javascript/dashboard/routes/dashboard/settings/inbox/components/BusinessDay.vue b/app/javascript/dashboard/routes/dashboard/settings/inbox/components/BusinessDay.vue index c8ccea5dc..0c5dd6c68 100644 --- a/app/javascript/dashboard/routes/dashboard/settings/inbox/components/BusinessDay.vue +++ b/app/javascript/dashboard/routes/dashboard/settings/inbox/components/BusinessDay.vue @@ -10,7 +10,6 @@ export default { props: { dayName: { type: String, - default: '', required: true, }, timeSlot: {